Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDBetteridge/randomfields rebased #3799

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

JDBetteridge
Copy link
Member

@JDBetteridge JDBetteridge commented Oct 15, 2024

Description

Anyone remember this fossil?

This PR allows users to sample functions from some Gaussian random field with Matern covariance.

I'm no better at statistics than when I wrote this code (a long time ago) and someone should probably check the properties.

Still needs some tests and there has to be a better way of doing the boundary thing* @connorjward? @UZerbinati does netgen handle this kind of thing?

  • For meshes with a boundary, the mesh needs to be grown by the size of the correlation length and then needs to be trimmed back to the original mesh. I think this might be quite a hard thing to do in general.

some_notes.pdf

Copy link

github-actions bot commented Oct 15, 2024

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real8074 ran7288 passed786 skipped0 failed

Copy link

github-actions bot commented Oct 15, 2024

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8068 ran6487 passed1581 skipped0 failed

@JDBetteridge JDBetteridge force-pushed the JDBetteridge/randomfields_rebased branch from fb46b8d to 4d89be3 Compare October 15, 2024 21:54
@UZerbinati
Copy link
Contributor

I think we might be able to do this with Netgen mesh extrusion (https://docu.ngsolve.org/latest/i-tutorials/unit-4.4-occ/workplane.html) or using the Boundary Layer method.

@connorjward
Copy link
Contributor

I think extending the boundary regions is a meshing/geometry problem which Firedrake isn't very well-suited to fixing. Netgen or GMSH are probably the way to go.

I also wonder if @ksagiyam's submesh stuff would be useful for handling the inner mesh.

@connorjward
Copy link
Contributor

This was discussed in the latest Firedrake meeting.

@JDBetteridge are you looking to work on this yourself? Or are you hoping someone else can take over? If the latter then it would be extremely useful if you could provide some tests (that don't necessarily need to pass) that demonstrate usage and expected behaviour.

@JDBetteridge
Copy link
Member Author

I'm intending to hand this over, but my intention is to provide tests. I have some tests already, but they need refactoring into py-test tests. Currently they are trying to assess statistics of these fields and are not suitable for the test suite as they take far too long to run!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants